mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
feat: decouple read FeedId from inbound MailboxId
Separate the two feed identities so the public read URL never reveals the inbound address and vice-versa: - FeedId becomes an opaque high-entropy token (read id + KV key); MailboxId (noun.noun.NN) owns the inbound address and the untrusted-input boundary via MailboxId.parse. They map only through the inbound:<mailbox> secondary index, resolved solely at reception. - inbound index lifecycle is owned by FeedRepository: written by save/saveConfig, dropped by removeFromList(Bulk) — symmetric, never mirrored by hand (removes the manual delete in feed-service + the cron loop, and a silent empty-catch). - Feed.mailboxId exposes a MailboxId VO (symmetry with Feed.id); the mailbox@domain shape lives on MailboxId.emailAddress(domain). - Distinguish mailbox_unknown (no feed claims the address) from feed_not_found (dangling index) for observability; both forwardable, both 404. - Drop the redundant EmailParser.extractMailbox pass-through so MailboxId.parse is the single parse boundary. Docs (README/INSTALL/CLAUDE.md/landing) and tests updated; 439 tests green, tsc clean, build dry-run OK. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { EmailParser } from "../domain/email-parser";
|
||||
import { MailboxId } from "../domain/value-objects/mailbox-id";
|
||||
import { AttachmentData, EmailMetadata, Env } from "../types";
|
||||
import { bumpCounters } from "../application/stats";
|
||||
import { dispatchFeedEvents } from "../application/feed-events";
|
||||
@@ -33,6 +33,7 @@ export interface ProcessEmailInput {
|
||||
|
||||
export type IngestRejectionReason =
|
||||
| "invalid_address"
|
||||
| "mailbox_unknown"
|
||||
| "feed_not_found"
|
||||
| "feed_expired"
|
||||
| "sender_blocked";
|
||||
@@ -79,17 +80,33 @@ async function loadAcceptingFeed(
|
||||
): Promise<
|
||||
{ ok: true; feed: Feed } | { ok: false; reason: IngestRejectionReason }
|
||||
> {
|
||||
const feedId = EmailParser.extractFeedId(input.toAddress);
|
||||
if (!feedId) {
|
||||
// MailboxId.parse is the single boundary where an untrusted inbound address
|
||||
// (the most untrusted input in the system) becomes a validated mailbox.
|
||||
const mailbox = MailboxId.parse(input.toAddress);
|
||||
if (!mailbox) {
|
||||
logger.error("Invalid email address format", {
|
||||
toAddress: input.toAddress,
|
||||
});
|
||||
return { ok: false, reason: "invalid_address" };
|
||||
}
|
||||
|
||||
const feed = await FeedRepository.from(env).load(feedId);
|
||||
// Resolve the inbound mailbox to the feed's opaque id (decoupled identities).
|
||||
const repo = FeedRepository.from(env);
|
||||
const feedId = await repo.resolveInbound(mailbox);
|
||||
if (!feedId) {
|
||||
// No feed claims this address — the common "wrong/unknown alias" case.
|
||||
logger.error("Unknown inbound mailbox", { mailbox: mailbox.value });
|
||||
return { ok: false, reason: "mailbox_unknown" };
|
||||
}
|
||||
|
||||
const feed = await repo.load(feedId);
|
||||
if (!feed) {
|
||||
logger.error("Feed not found", { feedId: feedId.value });
|
||||
// The index resolved but the feed is gone — a dangling index (should be
|
||||
// near-impossible now the index is dropped on feed deletion).
|
||||
logger.error("Feed not found", {
|
||||
mailbox: mailbox.value,
|
||||
feedId: feedId.value,
|
||||
});
|
||||
return { ok: false, reason: "feed_not_found" };
|
||||
}
|
||||
if (feed.isExpired()) {
|
||||
|
||||
Reference in New Issue
Block a user