mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
refactor: separate Feed domain state from persistence DTO
Move four DDD tensions on the Feed aggregate to ground: - #1 The aggregate now holds a domain FeedState (camelCase) instead of the snake_case FeedConfig DTO; infrastructure/feed-mapper.ts owns the FeedState<->FeedConfig/FeedListItem translation as the sole snake_case site outside the HTTP edge. - #3 Replace the edit() recomputeExpiry control flag with a Lifetime VO: passing a lifetime recomputes expiry, omitting it preserves the current one (the dashboard quick-edit path). - #4 Domain events carry their own feedId; dispatchFeedEvents centralizes the drain+dispatch in the application layer (no more manual pullEvents at call sites), keeping infra->application dependency direction intact. - #6 Rename FeedId.fromTrusted to FeedId.unchecked to make the absence of revalidation explicit. Adds Lifetime + feed-mapper round-trip tests. 353 tests green, tsc clean, wrangler dry-run OK. Docs (CLAUDE.md) synced. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -10,6 +10,7 @@ import { FEEDS_LIST_KEY } from "../config/constants";
|
||||
import { feedKeys } from "../domain/feed-keys";
|
||||
import { Feed } from "../domain/feed.aggregate";
|
||||
import { FeedId } from "../domain/value-objects/feed-id";
|
||||
import { fromConfigDTO, toConfigDTO, toListItemDTO } from "./feed-mapper";
|
||||
import { logger } from "./logger";
|
||||
|
||||
/**
|
||||
@@ -69,19 +70,23 @@ export class FeedRepository {
|
||||
this.getMetadata(feedId),
|
||||
]);
|
||||
if (!config) return null;
|
||||
return Feed.reconstitute(feedId, config, metadata ?? { emails: [] });
|
||||
return Feed.reconstitute(
|
||||
feedId,
|
||||
fromConfigDTO(config),
|
||||
metadata ?? { emails: [] },
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Persist both keys the aggregate owns (config + metadata) and keep the global
|
||||
* `feeds:list` entry in sync. The registry projection is derived from
|
||||
* `feed.summary()` here, so no caller has to remember to mirror it.
|
||||
* `feeds:list` entry in sync. Config/list DTOs are derived from the aggregate's
|
||||
* domain `state()` via `feed-mapper`, so no caller has to mirror snake_case.
|
||||
*/
|
||||
async save(feed: Feed): Promise<void> {
|
||||
await Promise.all([
|
||||
this.putConfig(feed.id, feed.toConfigSnapshot()),
|
||||
this.putConfig(feed.id, toConfigDTO(feed.state())),
|
||||
this.putMetadata(feed.id, feed.toMetadataSnapshot()),
|
||||
this.upsertListEntry(feed.summary()),
|
||||
this.upsertListEntry(toListItemDTO(feed.id, feed.state())),
|
||||
]);
|
||||
}
|
||||
|
||||
@@ -101,8 +106,8 @@ export class FeedRepository {
|
||||
*/
|
||||
async saveConfig(feed: Feed): Promise<void> {
|
||||
await Promise.all([
|
||||
this.putConfig(feed.id, feed.toConfigSnapshot()),
|
||||
this.upsertListEntry(feed.summary()),
|
||||
this.putConfig(feed.id, toConfigDTO(feed.state())),
|
||||
this.upsertListEntry(toListItemDTO(feed.id, feed.state())),
|
||||
]);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user