GitHub/jellyfin-plugin-sso
1
0
Fork 0
mirror of https://github.com/9p4/jellyfin-plugin-sso.git synced 2026-09-19 13:12:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Log permissions on permission error

Browse Source
This commit is contained in:
Sambhav Saggi
2022-02-25 19:47:06 -05:00
parent ff0f6caa3c
commit b752f6ffaa
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SSO-Auth/Api/SSOController.cs
+18 -3
View File
@@ -1,5 +1,6 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using System.Net.Mime; using System.Net.Mime;
using System.Text.RegularExpressions; using System.Text.RegularExpressions;
using System.Threading.Tasks; using System.Threading.Tasks;
@@ -71,7 +72,11 @@ public class SSOController : ControllerBase
var result = oidcClient.ProcessResponseAsync(Request.QueryString.Value, state).Result; var result = oidcClient.ProcessResponseAsync(Request.QueryString.Value, state).Result;
if (result.IsError) if (result.IsError)
{ {
return BadRequest(result.Error + " Try logging in again."); var errorResult = new ContentResult();
errorResult.Content = result.Error + " Try logging in again.";
errorResult.ContentType = "text/plain";
errorResult.StatusCode = 400;
return errorResult;
} }
if (!config.EnableFolderRoles) if (!config.EnableFolderRoles)
@@ -189,7 +194,12 @@ public class SSOController : ControllerBase
} }
else else
{ {
return BadRequest("Error. Check permissions."); _logger.LogWarning("OpenID user " + StateManager[Request.Query["state"]].Username + " has incorrect claims: " + string.Join(", ", result.User.Claims.Select(o => new { o.Type, o.Value })));
var errorResult = new ContentResult();
errorResult.Content = "Error. Check permissions.";
errorResult.ContentType = "text/plain";
errorResult.StatusCode = 401;
return errorResult;
} }
} }
} }
@@ -354,7 +364,12 @@ public class SSOController : ControllerBase
} }
} }
return Forbid("401 Forbidden"); // TODO: Return error code as well _logger.LogWarning("SAML user " + samlResponse.GetNameID() + " has insufficient roles: " + string.Join(", ", samlResponse.GetCustomAttributes("Role")));
var errorResult = new ContentResult();
errorResult.Content = "Error. Check permissions.";
errorResult.ContentType = "text/plain";
errorResult.StatusCode = 401;
return errorResult;
} }
} }