Files
thatguygriff 494c6df2c3
Validate / Hassfest validation (pull_request) Has been skipped
Validate / HACS validation (pull_request) Has been skipped
fix(climate): keep optimistic state until DKN cloud catches up
The DKN cloud REST endpoint lags behind the unit for several seconds
after a write, even though the unit itself and the DKN app reflect
the change immediately. The previous 2.5s optimistic-overlay TTL
expired well before the cloud caught up, so the next coordinator
publish (REST poll or socket device-data push) carried stale values
and the HA UI reverted to the previous setting.

Extend the overlay TTL to 30s as a safety bound, and track the
underlying device key + expected device value alongside each overlay.
On every coordinator publish, clear overlays whose device key now
reports the expected value (cloud has confirmed). The TTL still
caps how long a silently-failed write can hold a wrong value.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-27 09:49:04 -03:00

161 lines
6.0 KiB
Python

"""Shared base entity for DKN Cloud NA."""
from __future__ import annotations
import asyncio
import time
from typing import Any
from homeassistant.helpers.device_registry import CONNECTION_NETWORK_MAC, DeviceInfo
from homeassistant.helpers.update_coordinator import CoordinatorEntity
from .const import (
DOMAIN,
MANUFACTURER,
OPTIMISTIC_TTL_SEC,
POST_WRITE_REFRESH_DELAY_SEC,
)
from .coordinator import DknCoordinator
class DknEntity(CoordinatorEntity[DknCoordinator]):
"""Base class for all DKN Cloud NA entities.
Provides:
- device_info populated from the device's MAC and name.
- Per-device asyncio.Lock for serializing concurrent writes.
- Optimistic overlay: _optimistic_set() / _optimistic_get() / _optimistic_clear()
so entities can show a locally-set value until the coordinator refreshes.
- _schedule_refresh(): coalesced post-write coordinator refresh.
"""
_attr_has_entity_name = True
def __init__(self, coordinator: DknCoordinator, mac: str) -> None:
super().__init__(coordinator)
self._mac = mac
@property
def _device_data(self) -> dict[str, Any]:
"""Return raw device dict from coordinator, or empty dict if unavailable."""
return (self.coordinator.data or {}).get(self._mac, {})
@property
def _command_mac(self) -> str:
"""Return the device MAC in the form expected by the cloud API."""
mac = self._device_data.get("mac")
if isinstance(mac, str) and mac.strip():
return mac.strip()
return self._mac.upper()
@property
def device_info(self) -> DeviceInfo:
data = self._device_data
return DeviceInfo(
identifiers={(DOMAIN, self._mac)},
connections={(CONNECTION_NETWORK_MAC, self._mac)},
name=data.get("name") or self._mac,
manufacturer=MANUFACTURER,
sw_version=data.get("version"),
)
# ------------------------------------------------------------------
# Per-device write lock
# ------------------------------------------------------------------
def _get_device_lock(self) -> asyncio.Lock:
"""Return (creating if needed) the asyncio.Lock for this device."""
bucket = self.hass.data.setdefault(DOMAIN, {}).setdefault(
self.coordinator.entry_id, {}
)
locks: dict[str, asyncio.Lock] = bucket.setdefault("device_locks", {})
if self._mac not in locks:
locks[self._mac] = asyncio.Lock()
return locks[self._mac]
# ------------------------------------------------------------------
# Optimistic overlays
# ------------------------------------------------------------------
def _optimistic_set(
self,
key: str,
value: Any,
*,
device_key: str | None = None,
device_value: Any = None,
) -> None:
"""Store a locally-set value with a TTL timestamp.
When ``device_key`` is provided, ``_reconcile_optimistic`` will clear
the overlay as soon as the device data reports ``device_value`` for
that key — i.e. as soon as the cloud confirms the write.
"""
bucket = self.hass.data.setdefault(DOMAIN, {}).setdefault(
self.coordinator.entry_id, {}
)
overlays: dict[str, dict[str, Any]] = bucket.setdefault("optimistic", {})
device_overlays = overlays.setdefault(self._mac, {})
device_overlays[key] = {
"value": value,
"expires": time.monotonic() + OPTIMISTIC_TTL_SEC,
"device_key": device_key,
"device_value": device_value,
}
def _optimistic_get(self, key: str, fallback: Any) -> Any:
"""Return the optimistic value if still fresh, else fallback."""
bucket = self.hass.data.get(DOMAIN, {}).get(self.coordinator.entry_id, {})
overlays = bucket.get("optimistic", {}).get(self._mac, {})
entry = overlays.get(key)
if entry and time.monotonic() < entry["expires"]:
return entry["value"]
return fallback
def _optimistic_clear(self, key: str) -> None:
"""Expire an optimistic overlay immediately."""
bucket = self.hass.data.get(DOMAIN, {}).get(self.coordinator.entry_id, {})
overlays = bucket.get("optimistic", {}).get(self._mac, {})
overlays.pop(key, None)
def _reconcile_optimistic(self) -> None:
"""Clear overlays whose tracked device key now reports the expected value."""
bucket = self.hass.data.get(DOMAIN, {}).get(self.coordinator.entry_id, {})
overlays = bucket.get("optimistic", {}).get(self._mac)
if not overlays:
return
device = self._device_data
for overlay_key in list(overlays):
entry = overlays[overlay_key]
device_key = entry.get("device_key")
if device_key is None:
continue
if device.get(device_key) == entry["device_value"]:
overlays.pop(overlay_key, None)
def _handle_coordinator_update(self) -> None:
self._reconcile_optimistic()
super()._handle_coordinator_update()
# ------------------------------------------------------------------
# Post-write coordinator refresh (coalesced)
# ------------------------------------------------------------------
def _schedule_refresh(self) -> None:
"""Schedule a coordinator refresh after POST_WRITE_REFRESH_DELAY_SEC.
Multiple calls within the window collapse into a single refresh.
"""
bucket = self.hass.data.setdefault(DOMAIN, {}).setdefault(
self.coordinator.entry_id, {}
)
existing: asyncio.Task | None = bucket.get("pending_refresh")
if existing and not existing.done():
return
async def _do_refresh() -> None:
await asyncio.sleep(POST_WRITE_REFRESH_DELAY_SEC)
await self.coordinator.async_request_refresh()
bucket["pending_refresh"] = self.hass.async_create_task(_do_refresh())