mirror of
https://github.com/JHDev2006/Super-Mario-Bros.-Remastered-Public.git
synced 2025-10-22 15:38:14 +00:00
Miscellaneous Bugfixes From My Multiplayer Branch
This is just a bunch of bugfixes I did while I was working on the Multiplayer Support PR. I know I should've kept them separate, but then I'd also be dealing with said bugs. So this PR adds most of the bugfixes I did while working on Multiplayer. - De-globalized Pipe SFX from Pipe Cutscene (helps with lowering audio) - De-globalized 1-up SFX for Players - Removed an error log spam with the `ResourceSetter`s (involving connecting already connected signals) - Made sure to insert "BaseAssets" folder into the FIRST slot in the Resource Packs array. - Replaced `"BaseAssets"` for the above fix with `Godot.ROM_PACK_NAME` - Removed unused `"character"` setting from `SettingsManager` - Reset P-Switch timer when `Global.reset_values()` is called. Fixes bug when pressing a P-Switch and immediately restarting the level. - Added Skid SFX to `AudioManager` - Added slightly longer delay for when pausing with a controller (it can easily unpause before you press the button again) - Null check if LevelBG is in the level or not (for added for test levels)
This commit is contained in:
@@ -425,7 +425,7 @@ func add_stomp_combo(award_score := true) -> void:
|
||||
score_note_spawner.spawn_note(10000)
|
||||
else:
|
||||
Global.lives += 1
|
||||
AudioManager.play_global_sfx("1_up")
|
||||
AudioManager.play_sfx("1_up", global_position)
|
||||
score_note_spawner.spawn_one_up_note()
|
||||
else:
|
||||
if award_score:
|
||||
@@ -564,8 +564,6 @@ func die(pit := false) -> void:
|
||||
visible = not pit
|
||||
flight_meter = 0
|
||||
dead.emit()
|
||||
Global.p_switch_active = false
|
||||
Global.p_switch_timer = 0
|
||||
stop_all_timers()
|
||||
Global.total_deaths += 1
|
||||
sprite.process_mode = Node.PROCESS_MODE_ALWAYS
|
||||
@@ -804,8 +802,6 @@ func jump() -> void:
|
||||
gravity = JUMP_GRAVITY
|
||||
AudioManager.play_sfx("small_jump" if power_state.hitbox_size == "Small" else "big_jump", global_position)
|
||||
has_jumped = true
|
||||
await get_tree().physics_frame
|
||||
has_jumped = true
|
||||
|
||||
func calculate_jump_height() -> float: # Thanks wye love you xxx
|
||||
return -(JUMP_HEIGHT + JUMP_INCR * int(abs(velocity.x) / 25))
|
||||
|
Reference in New Issue
Block a user