mirror of
https://github.com/1Password/onepassword-operator.git
synced 2025-10-22 23:48:05 +00:00
eda5612827
This does the following updates: * Upgrade to Operator SDK v1.34.1. This fixes building multi-arch images from Makefile. Check this MR from operator-framework for details. * Update Go dependencies. This addresses Dependabot alert ["Golang protojson.Unmarshal function infinite loop when unmarshaling certain forms of invalid JSON"](https://github.com/1Password/onepassword-operator/security/dependabot/13). * Update versions of the GitHub Actions used in the pipelines. * Update Kubernetes related tools (such as controller-tools version, and operator-sdk for ci pipelines) By updating dependencies, the pipelines no longer fail due to a panic error when running `make test`.
171 lines
5.2 KiB
YAML
171 lines
5.2 KiB
YAML
linters:
|
|
disable-all: true
|
|
enable:
|
|
- asasalint
|
|
- asciicheck
|
|
- bidichk
|
|
- bodyclose
|
|
- dogsled
|
|
- dupl
|
|
- errcheck
|
|
- errchkjson
|
|
- errorlint
|
|
- exhaustive
|
|
- exportloopref
|
|
- ginkgolinter
|
|
- goconst
|
|
- gocritic
|
|
- gocyclo
|
|
- gofmt
|
|
- goimports
|
|
- goprintffuncname
|
|
- gosec
|
|
- gosimple
|
|
- govet
|
|
- importas
|
|
- ineffassign
|
|
- makezero
|
|
- misspell
|
|
- nakedret
|
|
- nilerr
|
|
- nolintlint
|
|
- prealloc
|
|
- revive
|
|
- staticcheck
|
|
- stylecheck
|
|
- tagliatelle
|
|
- typecheck
|
|
- unconvert
|
|
- unparam
|
|
- unused
|
|
- whitespace
|
|
|
|
linters-settings:
|
|
importas:
|
|
no-unaliased: true
|
|
alias:
|
|
# Kubernetes
|
|
- pkg: k8s.io/api/core/v1
|
|
alias: corev1
|
|
- pkg: k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1
|
|
alias: apiextensionsv1
|
|
- pkg: k8s.io/apimachinery/pkg/apis/meta/v1
|
|
alias: metav1
|
|
- pkg: k8s.io/apimachinery/pkg/api/errors
|
|
alias: apierrors
|
|
- pkg: k8s.io/apimachinery/pkg/util/errors
|
|
alias: kerrors
|
|
# Controller Runtime
|
|
- pkg: sigs.k8s.io/controller-runtime
|
|
alias: ctrl
|
|
staticcheck:
|
|
go: "1.21"
|
|
stylecheck:
|
|
go: "1.21"
|
|
revive:
|
|
rules:
|
|
# The following rules are recommended https://github.com/mgechev/revive#recommended-configuration
|
|
- name: blank-imports
|
|
- name: context-as-argument
|
|
- name: context-keys-type
|
|
- name: dot-imports
|
|
- name: error-return
|
|
- name: error-strings
|
|
- name: error-naming
|
|
- name: exported
|
|
- name: if-return
|
|
- name: increment-decrement
|
|
- name: var-naming
|
|
- name: var-declaration
|
|
- name: range
|
|
- name: receiver-naming
|
|
- name: time-naming
|
|
- name: unexported-return
|
|
- name: indent-error-flow
|
|
- name: errorf
|
|
- name: superfluous-else
|
|
- name: unreachable-code
|
|
- name: redefines-builtin-id
|
|
#
|
|
# Rules in addition to the recommended configuration above.
|
|
#
|
|
- name: bool-literal-in-expr
|
|
- name: constant-logical-expr
|
|
|
|
issues:
|
|
max-same-issues: 0
|
|
max-issues-per-linter: 0
|
|
# We are disabling default golangci exclusions because we want to help reviewers to focus on reviewing the most relevant
|
|
# changes in PRs and avoid nitpicking.
|
|
exclude-use-default: false
|
|
# List of regexps of issue texts to exclude, empty list by default.
|
|
exclude:
|
|
# The following are being worked on to remove their exclusion. This list should be reduced or go away all together over time.
|
|
# If it is decided they will not be addressed they should be moved above this comment.
|
|
- Subprocess launch(ed with variable|ing should be audited)
|
|
- (G204|G104|G307)
|
|
- "ST1000: at least one file in a package should have a package comment"
|
|
exclude-rules:
|
|
- linters:
|
|
- gosec
|
|
text: "G108: Profiling endpoint is automatically exposed on /debug/pprof"
|
|
- linters:
|
|
- revive
|
|
text: "exported: exported method .*\\.(Reconcile|SetupWithManager|SetupWebhookWithManager) should have comment or be unexported"
|
|
- linters:
|
|
- errcheck
|
|
text: Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked
|
|
- linters:
|
|
- staticcheck
|
|
text: "SA1019: .*The component config package has been deprecated and will be removed in a future release."
|
|
# With Go 1.16, the new embed directive can be used with an un-named import,
|
|
# revive (previously, golint) only allows these to be imported in a main.go, which wouldn't work for us.
|
|
# This directive allows the embed package to be imported with an underscore everywhere.
|
|
- linters:
|
|
- revive
|
|
source: _ "embed"
|
|
# Exclude some packages or code to require comments, for example test code, or fake clients.
|
|
- linters:
|
|
- revive
|
|
text: exported (method|function|type|const) (.+) should have comment or be unexported
|
|
source: (func|type).*Fake.*
|
|
- linters:
|
|
- revive
|
|
text: exported (method|function|type|const) (.+) should have comment or be unexported
|
|
path: fake_\.go
|
|
# Disable unparam "always receives" which might not be really
|
|
# useful when building libraries.
|
|
- linters:
|
|
- unparam
|
|
text: always receives
|
|
# Dot imports for gomega and ginkgo are allowed
|
|
# within test files.
|
|
- path: _test\.go
|
|
text: should not use dot imports
|
|
- path: _test\.go
|
|
text: cyclomatic complexity
|
|
- path: _test\.go
|
|
text: "G107: Potential HTTP request made with variable url"
|
|
# Append should be able to assign to a different var/slice.
|
|
- linters:
|
|
- gocritic
|
|
text: "appendAssign: append result not assigned to the same slice"
|
|
- linters:
|
|
- gocritic
|
|
text: "singleCaseSwitch: should rewrite switch statement to if statement"
|
|
# It considers all file access to a filename that comes from a variable problematic,
|
|
# which is naiv at best.
|
|
- linters:
|
|
- gosec
|
|
text: "G304: Potential file inclusion via variable"
|
|
- linters:
|
|
- dupl
|
|
path: _test\.go
|
|
|
|
run:
|
|
timeout: 10m
|
|
skip-files:
|
|
- "zz_generated.*\\.go$"
|
|
- ".*conversion.*\\.go$"
|
|
allow-parallel-runners: true
|