* Add missing improvements from Operator SDK 1.34.1
These were not mentioned in the upgrade documentation for version 1.34.x (https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.34.0/), but I've found them by compating the release with the previous one (https://github.com/operator-framework/operator-sdk/compare/v1.33.0...v1.34.1).
* Upgrade to Operator SDK 1.36.0
Source of upgrade steps: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.36.0/
Key differences:
- Go packages `k8s.io/*` are already at a version higher than the one in the upgrade.
- `ENVTEST_K8S_VERSION` is at a version higher than the one in the upgrade
- We didn't have the golangci-lint make command before, thus we only needed to add things.
* Upgrade to Operator SDK 1.38.0
Source of upgrade steps: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/
* Upgrade to Operator SDK 1.39.0
Source of upgrade steps: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.39.0/
* Upgrade to Operator SDK 1.40.0
Source of upgrade steps: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/
I didn't do the "Add app.kubernetes.io/name label to your manifests" since it seems that we have it already, and it's customized.
* Address lint errors
* Update golangci-lint version used to support Go 1.24
* Improve workflows
- Make workflow targets more specific.
- Make build workflow only build (i.e. remove test part of it).
- Rearrange steps and improve naming for build workflow.
* Add back deleted test
Initially the test has been removed due to lint saying that it was duplicate code, but it falsely errored since the values are different.
* Improve code and add missing upgrade pieces
* Upgrade to Operator SDK 1.41.1
Source of upgrade steps: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.41.0/
Upgrading to 1.41.1 from 1.40.0 doesn't have any migration steps.
Key elements:
- Upgrade to golangci-lint v2
- Made the manifests using the updated controller tools
* Address linter errors
golanci-lint v2 seems to be more robust than the previous one, which is beneficial. Thus, we address the linter errors thrown by v2 and improve our code even further.
* Add Makefile improvements
These were brought in by comparing the Makefile of a freshly created operator using the latest operator-sdk with ours.
* Add missing default kustomization for 1.40.0 upgrade
* Bring default kustomization to latest version
This is done by putting the file's content from a newly-generated operator.
* Switch metrics-bind-address default value back to 8080
This ensures that the upgrade is backwards-compatible.
* Add webhook-related scaffolding
This enables us to easily add support for webhooks by running `operator-sdk create webhook` whenever we want to add them.
* Fix typo
These internal models are introduced to reduce decoupling. The idea is to operate internal model within the project boundaries and convert to appropriate Connect or SDK models in the places where it's necessary.
This does the following updates:
* Upgrade to Operator SDK v1.34.1. This fixes building multi-arch images from Makefile. Check this MR from operator-framework for details.
* Update Go dependencies. This addresses Dependabot alert ["Golang protojson.Unmarshal function infinite loop when unmarshaling certain forms of invalid JSON"](https://github.com/1Password/onepassword-operator/security/dependabot/13).
* Update versions of the GitHub Actions used in the pipelines.
* Update Kubernetes related tools (such as controller-tools version, and operator-sdk for ci pipelines)
By updating dependencies, the pipelines no longer fail due to a panic error when running `make test`.
* Move controller package inside internal directory
Based on the go/v4 project structure, the following changed:
- Pakcage `controllers` is now named `controller`
- Package `controller` now lives inside new `internal` directory
* Move main.go in cmd directory
Based on the new go/v4 project structure, `main.go` now lives in the `cmd` directory.
* Change package import in main.go
* Update go mod dependencies
Update the dependencies based on the versions obtained by creating a new operator project using `kubebuilder init --domain onepassword.com --plugins=go/v4`.
This is based on the migration steps provided to go from go/v3 to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4)
* Update vendor
* Adjust code for breaking changes from pkg update
sigs.k8s.io/controller-runtime package had breaking changes from v0.14.5 to v0.16.3. This commit brings the changes needed to achieve the same things using the new functionality avaialble.
* Adjust paths to connect yaml files
Since `main.go` is now in `cmd` directory, the paths to the files for deploying Connect have to be adjusted based on the new location `main.go` is executed from.
* Update files based on new structure and scaffolding
These changes are made based on the new project structure and scaffolding obtained when using the new go/v4 project structure.
These were done based on the migration steps mentioned when migrating to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4).
* Update config files
These updates are made based on the Kustomize v4 syntax.
This is part of the upgrate to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4)
* Update dependencies and GO version
* Update vendor
* Update Kubernetes tools versions
* Update operator version in Makefile
Now the version in the Makefile matches the version of the operator
* Update Operator SDK version in version.go
* Adjust generated deepcopy
It seems that the +build tag is no longer needed based on the latest generated scaffolding, therefore it's removed.
* Update copyright year
* Bring back missing changes from migration
Some customization in Makefile was lost during the migration process. Specifically, the namespace customization for `make deploy` command.
Also, we push changes to kustomization.yaml for making the deploy process smoother.
* Add RBAC perms for coordination.k8s.io
It seems that with the latest changes to Kubernetes and Kustomize, we need to add additional RBAC to the service account used so that it can properly access the `leases` resource.
* Optimize Dockerfile
Dockerfile had a step for caching dependencies (go mod download). However, this is already done by the vendor directory, which we include. Therefore, this step can be removed to make the image build time faster.
Ginkgo has switched to v2 and we should make use of it instead. It doesn't affect how we make tests, but we get the latest enhancements and improvements on the ways tests are executed.
Command executed: `operator-sdk create api --version v1 --kind OnePasswordItem --resource --controller`
`--group` flag is skipped because we don't have a group in the previous version of the operator and we want to make things consistent and not bring any breaking changes.
Command executed: `operator-sdk init --domain onepassword.com --repo github.com/1Password/onepassword-operator --plugins=go/v4-alpha --license=none`
- `--plugin=go/v4-alpha` is used to enable support for Apple Sillicon environments.
- `--license=none` is used since the only option is Apache, and we use the MIT license. `hack/boilerplate.go.txt` is updated with the MIT license instead.
