Connect has a delay when synchronizing files and returns a 500 error in this case, this function implements a retry mechanism. In this case we handle retries in the code and do not print redundunt errors in the POD logs.
These internal models are introduced to reduce decoupling. The idea is to operate internal model within the project boundaries and convert to appropriate Connect or SDK models in the places where it's necessary.
* Move controller package inside internal directory
Based on the go/v4 project structure, the following changed:
- Pakcage `controllers` is now named `controller`
- Package `controller` now lives inside new `internal` directory
* Move main.go in cmd directory
Based on the new go/v4 project structure, `main.go` now lives in the `cmd` directory.
* Change package import in main.go
* Update go mod dependencies
Update the dependencies based on the versions obtained by creating a new operator project using `kubebuilder init --domain onepassword.com --plugins=go/v4`.
This is based on the migration steps provided to go from go/v3 to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4)
* Update vendor
* Adjust code for breaking changes from pkg update
sigs.k8s.io/controller-runtime package had breaking changes from v0.14.5 to v0.16.3. This commit brings the changes needed to achieve the same things using the new functionality avaialble.
* Adjust paths to connect yaml files
Since `main.go` is now in `cmd` directory, the paths to the files for deploying Connect have to be adjusted based on the new location `main.go` is executed from.
* Update files based on new structure and scaffolding
These changes are made based on the new project structure and scaffolding obtained when using the new go/v4 project structure.
These were done based on the migration steps mentioned when migrating to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4).
* Update config files
These updates are made based on the Kustomize v4 syntax.
This is part of the upgrate to go/v4 (https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4)
* Update dependencies and GO version
* Update vendor
* Update Kubernetes tools versions
* Update operator version in Makefile
Now the version in the Makefile matches the version of the operator
* Update Operator SDK version in version.go
* Adjust generated deepcopy
It seems that the +build tag is no longer needed based on the latest generated scaffolding, therefore it's removed.
* Update copyright year
* Bring back missing changes from migration
Some customization in Makefile was lost during the migration process. Specifically, the namespace customization for `make deploy` command.
Also, we push changes to kustomization.yaml for making the deploy process smoother.
* Add RBAC perms for coordination.k8s.io
It seems that with the latest changes to Kubernetes and Kustomize, we need to add additional RBAC to the service account used so that it can properly access the `leases` resource.
* Optimize Dockerfile
Dockerfile had a step for caching dependencies (go mod download). However, this is already done by the vendor directory, which we include. Therefore, this step can be removed to make the image build time faster.
- `version` is used for getting the operator version and the operator SDK version in the logs.
- `k8suitl` is extracted from the operator-sdk to be able to fetch the namespace the operator is deployed to. This is used to deploy Connect in the same namespace if `MANAGE_CONNECT` is set to `true`. In the future, we may want to no rely on this, since this functionality is internal in the operator-sdk.
This makes it easier to see whehter the controller
succeeded in creating the Kubernetes secret for a
OnePasswordItem. If something failed, the `ready` field
will be `false` and the `OnePasswordItemReady` condition
will have a `status` of `False` with the error messages
in the `message` field.
