Addressing PR comments

This commit is contained in:
jillianwilson
2021-10-06 13:32:54 -03:00
parent f974d3f398
commit e6ca8d49ba
3 changed files with 5 additions and 5 deletions

View File

@@ -19,15 +19,15 @@ test: ## Run test suite
test/coverage: ## Run test suite with coverage report test/coverage: ## Run test suite with coverage report
go test -v ./... -cover go test -v ./... -cover
build: ## Build operator Docker image build/operator: ## Build operator Docker image
@docker build -f operator/Dockerfile --build-arg operator_version=$(curVersion) -t $(DOCKER_IMG_TAG) . @docker build -f operator/Dockerfile --build-arg operator_version=$(curVersion) -t $(DOCKER_IMG_TAG) .
@echo "Successfully built and tagged image." @echo "Successfully built and tagged image."
@echo "Tag: $(DOCKER_IMG_TAG)" @echo "Tag: $(DOCKER_IMG_TAG)"
build/local: ## Build local version of the operator Docker image build/operator/local: ## Build local version of the operator Docker image
@docker build -f operator/Dockerfile -t local/$(DOCKER_IMG_TAG) . @docker build -f operator/Dockerfile -t local/$(DOCKER_IMG_TAG) .
build/binary: clean ## Build operator binary build/operator/binary: clean ## Build operator binary
@mkdir -p dist @mkdir -p dist
@go build -mod vendor -a -o manager ./operator/cmd/manager/main.go @go build -mod vendor -a -o manager ./operator/cmd/manager/main.go
@mv manager ./dist @mv manager ./dist

View File

@@ -10,7 +10,7 @@ The 1Password Connect Kubernetes Operator also allows for Kubernetes Secrets to
The 1Password Connect Kubernetes Operator will continually check for updates from 1Password for any Kubernetes Secret that it has generated. If a Kubernetes Secret is updated, any Deployment using that secret can be automatically restarted. The 1Password Connect Kubernetes Operator will continually check for updates from 1Password for any Kubernetes Secret that it has generated. If a Kubernetes Secret is updated, any Deployment using that secret can be automatically restarted.
[Click here for more details on the 1Password Kubernetes Operator](https://github.com/1Password/onepassword-operator/operator) [Click here for more details on the 1Password Kubernetes Operator](operator/README.md)
# Security # Security

View File

@@ -16,7 +16,7 @@ ARG operator_version=dev
RUN CGO_ENABLED=0 \ RUN CGO_ENABLED=0 \
GO111MODULE=on \ GO111MODULE=on \
go build \ go build \
-ldflags "-X \"github.com/1Password/onepassword-operator/version.Version=$operator_version\"" \ -ldflags "-X \"github.com/1Password/onepassword-operator/operator/version.Version=$operator_version\"" \
-mod vendor \ -mod vendor \
-a -o manager operator/main.go -a -o manager operator/main.go