From d715a6ed0e1347e1767ff76b1495fbbd7fc56467 Mon Sep 17 00:00:00 2001 From: jillianwilson Date: Thu, 21 Oct 2021 17:21:10 -0300 Subject: [PATCH] Addressing pr comments --- operator/pkg/onepassword/onepassword_item.go | 2 +- operator/pkg/onepassword/secret_update_handler.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/operator/pkg/onepassword/onepassword_item.go b/operator/pkg/onepassword/onepassword_item.go index 31972e7..9c2d5fc 100644 --- a/operator/pkg/onepassword/onepassword_item.go +++ b/operator/pkg/onepassword/onepassword_item.go @@ -64,7 +64,7 @@ func CreateOnePasswordCRSecretFromReference(opClient connect.Client, kubeClient currentOnepassworditem := &onepasswordv1.OnePasswordItem{} err = kubeClient.Get(context.Background(), types.NamespacedName{Name: onepassworditem.Name, Namespace: onepassworditem.Namespace}, currentOnepassworditem) - if err != nil && errors.IsNotFound(err) { + if errors.IsNotFound(err) { log.Info(fmt.Sprintf("Creating OnePasswordItem CR %v at namespace '%v'", onepassworditem.Name, onepassworditem.Namespace)) return kubeClient.Create(context.Background(), onepassworditem) } else if err != nil { diff --git a/operator/pkg/onepassword/secret_update_handler.go b/operator/pkg/onepassword/secret_update_handler.go index abf8718..d76245c 100644 --- a/operator/pkg/onepassword/secret_update_handler.go +++ b/operator/pkg/onepassword/secret_update_handler.go @@ -162,14 +162,14 @@ func (h *SecretUpdateHandler) updateInjectedSecrets() (map[string]map[string]*on onepasswordItems := &onepasswordv1.OnePasswordItemList{} err := h.client.List(context.Background(), onepasswordItems) if err != nil { - log.Error(err, "Failed to list OneOasswordItems") + log.Error(err, "Failed to list OnePasswordItems") return nil, err } updatedItems := map[string]map[string]*onepasswordv1.OnePasswordItem{} for _, item := range onepasswordItems.Items { - // if onepassworditem was generated by injecting a secret into a deployment then ignore + // if onepassworditem was not generated by injecting a secret into a deployment then ignore _, injected := item.Annotations[InjectedAnnotation] if !injected { continue