From 5fab6624247e35faec68d61feeb407a99e138c8a Mon Sep 17 00:00:00 2001 From: Samuel Archambault Date: Fri, 24 Sep 2021 11:03:47 -0400 Subject: [PATCH] More logging if 1password item cant be read and continue processing others --- cmd/manager/main.go | 5 ++++- pkg/onepassword/secret_update_handler.go | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/cmd/manager/main.go b/cmd/manager/main.go index 2d7904c..05ca380 100644 --- a/cmd/manager/main.go +++ b/cmd/manager/main.go @@ -178,7 +178,10 @@ func main() { ticker.Stop() return case <-ticker.C: - updatedSecretsPoller.UpdateKubernetesSecretsTask() + err := updatedSecretsPoller.UpdateKubernetesSecretsTask() + if err != nil { + log.Error(err, "error running update kubernetes secret task") + } } } }() diff --git a/pkg/onepassword/secret_update_handler.go b/pkg/onepassword/secret_update_handler.go index ad2e8d6..d32f0b9 100644 --- a/pkg/onepassword/secret_update_handler.go +++ b/pkg/onepassword/secret_update_handler.go @@ -118,7 +118,8 @@ func (h *SecretUpdateHandler) updateKubernetesSecrets() (map[string]map[string]* item, err := GetOnePasswordItemByPath(h.opConnectClient, secret.Annotations[ItemPathAnnotation]) if err != nil { - return nil, fmt.Errorf("Failed to retrieve item: %v", err) + log.Error(err, "failed to retrieve 1Password item at path \"%s\" for secret \"%s\"", secret.Annotations[ItemPathAnnotation], secret.Name) + continue } itemVersion := fmt.Sprint(item.Version)