1Password/onepassword-operator
1
0
Fork 0
mirror of https://github.com/1Password/onepassword-operator.git synced 2025-10-22 07:28:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add TODOs for missing tests that need to be migrated

Browse Source
This commit is contained in:
Eddy Filip
2022-09-13 20:08:10 +03:00
parent c3094dbef0
commit 91eb658d70
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
controllers/deployment_controller_test.go
View File

@@ -46,6 +46,12 @@ var _ = Describe("Deployment controller", func() {
}
})
// TODO: Implement the following test cases:
// - Updating Existing K8s Secret using Deployment
// - Do not update if Annotations have not changed
// - Delete Deployment where secret is being used in another deployment's container
// - Delete Deployment where secret is being used in another deployment's volumes
Context("Deployment with secrets from 1Password", func() {
It("Should Handle a deployment correctly", func() {
ctx := context.Background()

7
controllers/onepassworditem_controller_test.go
View File

@@ -44,6 +44,13 @@ var _ = Describe("OnePasswordItem controller", func() {
}
})
// TODO: Implement the following missing tests:
// - K8s secret is not updated if OnePasswordItem Version or VaultPath has not changed
// - Update type of existing K8s Secret using OnePasswordItem
// - Create a custom K8s Secret type using OnePasswordItem (e.g. .dockerconfigjson)
// - Operator should throw an error if secret type is changed
// - Secret from 1Password item with `-`, `_` and `.`
Context("Happy path", func() {
It("Should handle 1Password Item and secret correctly", func() {
ctx := context.Background()