From 88728909ff28fca2a6f46da2be64628826aae3ce Mon Sep 17 00:00:00 2001 From: Eddy Filip Date: Wed, 8 Sep 2021 13:49:32 +0300 Subject: [PATCH] Adjust regex to support `_` and `.` and trim them Now secret names can also contain `_` and `.` and they will be trimmed from start and end of string to be DNS1123 compliant --- pkg/kubernetessecrets/kubernetes_secrets_builder.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubernetessecrets/kubernetes_secrets_builder.go b/pkg/kubernetessecrets/kubernetes_secrets_builder.go index f2b706b..49a7522 100644 --- a/pkg/kubernetessecrets/kubernetes_secrets_builder.go +++ b/pkg/kubernetessecrets/kubernetes_secrets_builder.go @@ -97,7 +97,7 @@ func formatSecretName(value string) string { return createValidSecretName(value) } -var invalidDNS1123Chars = regexp.MustCompile("[^a-zA-Z0-9-]+") +var invalidDNS1123Chars = regexp.MustCompile("[^a-zA-Z0-9-_.]+") func createValidSecretName(value string) string { result := invalidDNS1123Chars.ReplaceAllString(value, "-") @@ -107,5 +107,5 @@ func createValidSecretName(value string) string { } // first and last character MUST be alphanumeric - return strings.Trim(result, "-") + return strings.Trim(result, "-._") }