1Password/onepassword-operator
1
0
Fork 0
mirror of https://github.com/1Password/onepassword-operator.git synced 2025-10-22 15:38:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add max length for secret key names

Browse Source 
Max length for secret key names must be DNS1123 compliant (253)
This commit is contained in:
Eddy Filip
2021-09-08 16:02:08 +03:00
parent a45a310611
commit 670040477e
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/kubernetessecrets/kubernetes_secrets_builder.go
View File

@@ -129,5 +129,10 @@ var invalidStartEndChars = regexp.MustCompile("(^[^a-zA-Z0-9-._]+|[^a-zA-Z0-9-._
func createValidSecretDataName(value string) string { func createValidSecretDataName(value string) string {
result := invalidStartEndChars.ReplaceAllString(value, "") result := invalidStartEndChars.ReplaceAllString(value, "")
result = invalidDataChars.ReplaceAllString(result, "-") result = invalidDataChars.ReplaceAllString(result, "-")
if len(result) > kubeValidate.DNS1123SubdomainMaxLength {
result = result[0:kubeValidate.DNS1123SubdomainMaxLength]
}
return result return result
} }

2
pkg/kubernetessecrets/kubernetes_secrets_builder_test.go
View File

@@ -129,7 +129,7 @@ func TestBuildKubernetesSecretFixesInvalidLabels(t *testing.T) {
Value: "value1", Value: "value1",
}, },
{ {
Label: strings.Repeat("x", kubeValidate.LabelValueMaxLength+1), Label: strings.Repeat("x", kubeValidate.DNS1123SubdomainMaxLength+1),
Value: "name exceeds max length", Value: "name exceeds max length",
}, },
} }