diff --git a/test/e2e/e2e_test.go b/test/e2e/e2e_test.go index f55da5e..2d7a9a8 100644 --- a/test/e2e/e2e_test.go +++ b/test/e2e/e2e_test.go @@ -15,20 +15,15 @@ import ( ) const ( - operatorImage = "1password/onepassword-operator:latest" - defaultInterval = 1 * time.Second - defaultTimeout = 30 * time.Second + operatorImageName = "1password/onepassword-operator:latest" + defaultInterval = 1 * time.Second + defaultTimeout = 30 * time.Second ) var _ = Describe("Onepassword Operator e2e", Ordered, func() { BeforeAll(func() { - By("building the operator image") - _, err := cmd.Run("make", "docker-build") - ExpectWithOffset(1, err).NotTo(HaveOccurred()) - - By("loading the operator image on Kind") - err = kind.LoadImageToKind(operatorImage) - ExpectWithOffset(1, err).NotTo(HaveOccurred()) + operator.BuildOperatorImage() + kind.LoadImageToKind(operatorImageName) By("create onepassword-token secret") kube.CreateSecretFromEnvVar("OP_CONNECT_TOKEN", "onepassword-token") diff --git a/test/testhelper/kind/kind.go b/test/testhelper/kind/kind.go index f3d3b48..5ff8fbc 100644 --- a/test/testhelper/kind/kind.go +++ b/test/testhelper/kind/kind.go @@ -3,15 +3,19 @@ package kind import ( "os" + . "github.com/onsi/ginkgo/v2" + . "github.com/onsi/gomega" + "github.com/1Password/onepassword-operator/test/cmd" ) // LoadImageToKind loads a local docker image to the Kind cluster -func LoadImageToKind(imageName string) error { +func LoadImageToKind(imageName string) { + By("loading the operator image on Kind") clusterName := "kind" if value, ok := os.LookupEnv("KIND_CLUSTER"); ok { clusterName = value } _, err := cmd.Run("kind", "load", "docker-image", imageName, "--name", clusterName) - return err + Expect(err).NotTo(HaveOccurred()) } diff --git a/test/testhelper/operator/operator.go b/test/testhelper/operator/operator.go index 794efea..c56f5e0 100644 --- a/test/testhelper/operator/operator.go +++ b/test/testhelper/operator/operator.go @@ -10,6 +10,12 @@ import ( "github.com/1Password/onepassword-operator/test/testhelper/kube" ) +func BuildOperatorImage() { + By("building the operator image") + _, err := cmd.Run("make", "docker-build") + ExpectWithOffset(1, err).NotTo(HaveOccurred()) +} + // DeployOperator deploys the Onepassword Operator in the default namespace. // It waits for the operator pod to be in 'Running' state. // All the resources created using manifests in `config/` dir.