From 0b4b9d117f53f414f66c4a061c2797a561ddfe7c Mon Sep 17 00:00:00 2001 From: jillianwilson Date: Thu, 4 Nov 2021 16:58:17 -0300 Subject: [PATCH] Addressing PR comments --- Makefile | 4 ++-- README.md | 2 +- secret-injector/Dockerfile | 2 +- secret-injector/README.md | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 26ac80b..9d64873 100644 --- a/Makefile +++ b/Makefile @@ -11,9 +11,9 @@ versionFile = $(CURDIR)/.VERSION curVersion := $(shell cat $(versionFile) | sed 's/^v//') OPERATOR_NAME := onepassword-connect-operator -OPERATOR_NAME := onepassword-secrets-injector +INJECTOR_NAME := onepassword-secrets-injector OPERATOR_DOCKER_IMG_TAG ?= $(OPERATOR_NAME):v$(curVersion) -INJECTOR_DOCKER_IMG_TAG ?= $(OPERATOR_NAME):v$(curVersion) +INJECTOR_DOCKER_IMG_TAG ?= $(INJECTOR_NAME):v$(curVersion) test: ## Run test suite go test ./... diff --git a/README.md b/README.md index 3ff965f..07727bf 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ The 1Password Connect Kubernetes Operator will continually check for updates fro ## 1Password Secrets Injector for Kubernetes -The 1Password Secrets Injector for Kubernetes provides the ability to integrate Kubernetes with 1Password. The 1Password Secrets Injector implements a mutating webhook to inject 1Password secrets as environment variables into a pod or deployment. This differs from the secert creation provided by the 1Password Kubernetes operator in that a Kubernetes Secret will not be created when injecting a secret into your resource. +The 1Password Secrets Injector implements a mutating webhook to inject 1Password secrets as environment variables into a pod or deployment. Unlike the 1Password Kubernetes Operator, the Secrets Injector does not create a Kubernetes Secret when assigning secrets to your resource. [Click here for more details on the 1Password Secrets Injector for Kubernetes](secret-injector/README.md) diff --git a/secret-injector/Dockerfile b/secret-injector/Dockerfile index 4c74643..aac7e97 100644 --- a/secret-injector/Dockerfile +++ b/secret-injector/Dockerfile @@ -15,7 +15,7 @@ ARG secret_injector_version=dev RUN CGO_ENABLED=0 \ GO111MODULE=on \ go build \ - -ldflags "-X \"github.com/1Password/onepassword-operator/operator/version.Version=$secret_injector_version\"" \ + -ldflags "-X \"github.com/1Password/onepassword-operator/secret-injector/version.Version=$secret_injector_version\"" \ -mod vendor \ -a -o injector secret-injector/main.go diff --git a/secret-injector/README.md b/secret-injector/README.md index 2c0cb49..dd10bec 100644 --- a/secret-injector/README.md +++ b/secret-injector/README.md @@ -1,5 +1,5 @@ # 1Password Secrets Injector for Kubernetes -The 1Password Secrets Injector for Kubernetes provides the ability to integrate Kubernetes with 1Password. The 1Password Secrets Injector implements a mutating webhook to inject 1Password secrets as environment variables into a pod or deployment. This differs from the secert creation provided by the 1Password Kubernetes operator in that a Kubernetes Secret will not be created when injecting a secret into your resource. +The 1Password Secrets Injector implements a mutating webhook to inject 1Password secrets as environment variables into a pod or deployment. Unlike the 1Password Kubernetes Operator, the Secrets Injector does not create a Kubernetes Secret when assigning secrets to your resource. ## Use with the 1Password Kubernetes Operator The 1Password Secrets Injector for Kubernetes can be used in conjuction with the 1Password Kubernetes Operator in order to provide automatic deployment restarts when a 1Password item being used by your deployment has been updated. @@ -108,7 +108,7 @@ spec: value: op://my-vault/my-item/sql/username - name: DB_PASSWORD value: op://my-vault/my-item/sql/password - - name: my-app //because my-app is not listed in the inject annotaion above the environment values for this container will not be updated with secret values + - name: my-app //because my-app is not listed in the inject annotation above this container will not be injected with secrets image: my-image env: - name: DB_USERNAME